-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find an alternative distribution channel to JPM #22
Comments
Hi @yaravind, That sounds amazing, we would really appreciate your contribution! Let us know if you need anything. |
@yaravind do you have any updates on this? can we help in something? |
|
hey @halkeye ! really happy to hear that ! To figure out commit id, I would recommend to fetch from a env variable like we did on our sbt plugin Alternatively, you can assume you are in a git folder and exec a git command - through a command (example) or using a git library. |
Can you upgrade to netty-http-pipeline 1.1.4 so it can be pulled from maven central? typesafehub/netty-http-pipelining#13 |
Yea, trying to do excludes and stuff, i get: [ERROR] Failed to execute goal com.gavinmogan:codacy-maven-plugin:1.0-SNAPSHOT:coverage (default-cli) on project ci-sauce: Execution default-cli of goal com.gavinmogan:codacy-maven-plugin:1.0-SNAPSHOT:coverage failed: An API incompatibility was encountered while executing com.gavinmogan:codacy-maven-plugin:1.0-SNAPSHOT:coverage: java.lang.NoSuchMethodError: org.jboss.netty.handler.codec.http.HttpRequest.setHeader(Ljava/lang/String;Ljava/lang/Object;)V So i don't think i can upgrade it just on my side. |
just did a pr that should fix your problem @halkeye Should fix the error regarding netty-http-pipelining dependency Also, removed codacy-api scala sdk from dependencies, since you should not need it. Probably you can use the coverage-parser to parse the coverage report, and then you just need to use codacy-api-java to send the coverage report parsed to our format. You should not need codacy-coverage-reporter. This plugin works as an alternative for codacy-coverage-reporter, so you shouldn't need it as a dependency
|
I can't imagine this is the best place for these conversations, but I'm kinda out of ideas. It gets into the sendReport function, and just hangs. Adding debugging gets me:
I know its blocked in
doesn't even get to |
MORE INFO! I switched to a java http client, just so i could better control what was going on I'm getting
|
Hey @halkeye The only thing I can think of is that you're wrapping the coverage report object in an array.
|
Sweeeet. Thanks, it was a slight bug in the hack I did. I'm going to have to refactor a bunch. I would love if one of the codacy api's could be updated to return the json object, 'cause java and scala doesn't want to play nice in that regard. But it is uploading.
Any idea how long it should take to show something @ https://www.codacy.com/app/halkeye/ci-sauce/dashboard?bid=3528956 |
Great! It shouldn't take more than a couple seconds as long as the commit has already been detected by Codacy. Just make sure you are using the right project token. |
oh sweet! it showed up. Does codacy have any interest in owning this long term? or should I try to eventually release this myself? |
at this moment is hard for us to own/maintain another project (we already have so many open source projects, and our team is not very big...), but we are available to help you maintain the project. If you need help to release just let us know and we will help you |
https://halkeye.github.io/codacy-maven-plugin/project-summary.html Just waiting for maven central to update, then i'll update readmes and stuff |
yep yep yep |
Improve error message when parsing failed (FT-4854)
I am trying to use codacy to enable code quality checks for my https://github.com/yaravind/kafka-connect-jenkins
It is getting very hard to install jpm on snap ci infrastructure. I was wondering if there is alternate way. Or if you can provide some details on where to start, I can contribute a maven plug-in to report the coverage (just like jococo maven plug-in)
The text was updated successfully, but these errors were encountered: