Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Update to the format used by the documented format CY-3490 #58

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Jan 20, 2021

This PR updates the format used by Scala tools to match the format we use in other languages.
The format is already understood by codacy-plugins so it's safe to update without any particular problem.
After there are no tools using file instead of filename, we can stop reading the file format in codacy-plugins.

@lolgab lolgab requested a review from a team January 20, 2021 11:45
@lolgab lolgab changed the title breaking: Update to the format used by the documented format breaking: Update to the format used by the documented format CY-3490 Jan 26, 2021
@betullkoyuncu
Copy link

Hello @lolgab! I observe that the issue (CY-3490) is moved to Technical Supports board and from 'review' to 'to do'. You probably would want to sync with @stefanvacareanu7 and we can see what to do with the PR and the issue. Let me know if you need a hand 🙏

Copy link

@betullkoyuncu betullkoyuncu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since codacy-plugins is okey with "fileName", this PR looks good to me 🚀

@stefanvacareanu7 stefanvacareanu7 merged commit e94cfa1 into master Nov 2, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the use-filename-instead-of-file branch November 2, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants