First release #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljmf00
force-pushed
the
luis-ferreira/first-release
branch
10 times, most recently
from
9102cc0
to
cfe0b1a
Compare
ljmf00
force-pushed
the
luis-ferreira/first-release
branch
4 times, most recently
from
681f896
to
f92c685
Compare
ljmf00
force-pushed
the
luis-ferreira/first-release
branch
from
f92c685
to
eeda03e
Compare
ljmf00
requested review from
andreaTP,
bmbferreira,
DReigada,
h314to,
lolgab,
paulopontesm,
pedrocodacy and
rtfpessoa
as code owners
mrfyda
reviewed
Oct 7, 2019
ljmf00
force-pushed
the
luis-ferreira/first-release
branch
from
eeda03e
to
509af18
Compare
ljmf00
force-pushed
the
luis-ferreira/first-release
branch
2 times, most recently
from
ed27bfd
to
2c92fa0
Compare
andreaTP
suggested changes
Oct 21, 2019
ljmf00
force-pushed
the
luis-ferreira/first-release
branch
3 times, most recently
from
fc8fd47
to
66cca3c
Compare
andreaTP
suggested changes
Oct 24, 2019
Dockerfile
Outdated
| @@ -0,0 +1,10 @@ | |||
| FROM mcr.microsoft.com/dotnet/core/runtime:2.2-alpine | |||
|
|
|||
| COPY src/Analyzer/bin/Release/netcoreapp2.2/publish/*.dll /opt/docker/bin/ | |||
There was a problem hiding this comment.
this is dependent from operations done on the host machine IIUC, can we use multi-stage build here?
There was a problem hiding this comment.
No, this just depends on the framework target, and here, we just use one framework target, which is netcoreapp2.2. The .dll file is CIL bytecode, so it's host independent. You just need to make sure you have the same runtime installed.
There was a problem hiding this comment.
this doesn't come with the repository itself.
Should be done in a multi-stage IMHO
ljmf00
force-pushed
the
luis-ferreira/first-release
branch
from
66cca3c
to
b97ce16
Compare
andreaTP
previously approved these changes
Oct 25, 2019
.circleci/config.yml
Outdated
| description: "Whether to cache bootstrap files" | ||
| default: false | ||
| docker: | ||
| #TODO: switch to docker image |
ljmf00
force-pushed
the
luis-ferreira/first-release
branch
from
b97ce16
to
37c51db
Compare
andreaTP
suggested changes
Oct 28, 2019
Dockerfile
Outdated
| @@ -0,0 +1,18 @@ | |||
| FROM mcr.microsoft.com/dotnet/core/sdk:2.2 | |||
There was a problem hiding this comment.
FROM mcr.microsoft.com/dotnet/core/sdk:2.2 AS buildimage
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
Signed-off-by: Luís Ferreira <contact@lsferreira.net>
ljmf00
force-pushed
the
luis-ferreira/first-release
branch
from
37c51db
to
b07bf86
Compare
andreaTP
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.