Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank screen for frontend errors #3819

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Fix blank screen for frontend errors #3819

merged 2 commits into from
Sep 28, 2021

Conversation

jzwang43
Copy link
Contributor

@jzwang43 jzwang43 commented Sep 27, 2021

Reasons for making this change

Blank screen show after edit source and then click save.

This is because error is an object and cannot be directly rendered. Because the error message is just error 404, I added clearer message to explain the error to user.

Related issues

#3651

Screenshots

a

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@jzwang43 jzwang43 self-assigned this Sep 27, 2021
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but does the error object already contain a message that we could show to the user? or is it better to hard-code the error message as we do in this PR?

@jzwang43
Copy link
Contributor Author

This seems fine, but does the error object already contain a message that we could show to the user? or is it better to hard-code the error message as we do in this PR?

The error.message just says something like "error 404" so I think it's better to give some more user-friendly error message.

@mergify mergify bot merged commit f7a5fa1 into master Sep 28, 2021
@mergify mergify bot deleted the fix-blank-screen branch September 28, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants