Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type:ignore mypy annotations in tar_subdir_stream #4533

Open
AndrewJGaut opened this issue Sep 20, 2023 · 1 comment · May be fixed by #4536
Open

Remove type:ignore mypy annotations in tar_subdir_stream #4533

AndrewJGaut opened this issue Sep 20, 2023 · 1 comment · May be fixed by #4536
Assignees
@HidyHan
Labels
p3 Do it some day. starter Good starter task (ideally straightforward).

Comments

@AndrewJGaut
Copy link
Contributor

We had some annotations to silence the type checker on some lines due to a missing type. However, we should now be able to remove those. (See here).

Let's remove them if possible.
@AndrewJGaut AndrewJGaut added starter Good starter task (ideally straightforward). p3 Do it some day. labels Sep 20, 2023
@HidyHan HidyHan linked a pull request Sep 24, 2023 that will close this issue
Open
@pranavjain
Copy link
Contributor

@HidyHan Can you close your PR which will fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HidyHan HidyHan

Labels
p3 Do it some day. starter Good starter task (ideally straightforward).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes stale annotator exception. HidyHan/codalab-worksheets
3 participants
@pranavjain @HidyHan @AndrewJGaut