2417: Fix mkdocs Travis failure #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicfaace
approved these changes
Jun 17, 2020
candicegjing
approved these changes
Jun 17, 2020
armantajback
added a commit
that referenced
this pull request
Jun 19, 2020
* Fix free disk bytes calculation (#2370) Closed via #2362 * Fix WorkerManager launching (#2372) Co-authored-by: Jing Ge <jingge2@illinois.edu> * Make worker id match output directory and job name (#2369) * Make worker id match output directory and job name * Blacken Co-authored-by: Jing Ge <jingge2@illinois.edu> * Pass down max work dir size and delete workdir on exit to slurm workers (#2354) * Pass down max work dir size and delete workdir on exit to slurm workers * Fix typo. Co-authored-by: Jing Ge <jingge2@illinois.edu> * == -> === (#2357) Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> * Refactor dialogs into worksheetDialog component (#2263) * merge openX to one open dialog variable * refactor error message, delete worksheet message, bundle action fail dialogs into worksheet dialog component * add check when using enter keyword Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> * remove context menu (#2376) * Update print information (#2382) Co-authored-by: Jing Ge <stanford@Stanfords-MacBook-Pro.local> * Add a CLI option to limit the number of jobs allowed to run on a worker (#2289) Closed via #2287 * Set cli verbose default to 0 (#2378) Closed via #2350 * Mounting dependencies on paths specified by keys (#2295) * Fix time displaying issue (#2381) * Fix datetime displaying issue * Add a comment Co-authored-by: Jing Ge <stanford@Stanfords-MacBook-Pro.local> Co-authored-by: yipenghe <yipenghe@stanford.edu> * overdue (#2393) * fix migration (#2403) * Make strings more consistent in terms of terminology / organization (#2409) * tweak dialog prompts * add cut/copied * organize keyboard shortcuts * fix formatting * remove dummy file * ignore a d when a dialog is opened Co-authored-by: yipenghe <yipenghe@stanford.edu> * Replace sacct with scontrol, since sacct is only available on the slurm head node (#2368) * Handle sort key is 0 condition on frontend and use correct sort key for new runs (#2412) * handle sort key is 0 condition * handle sort key is 0 in getAfterSortKey function * use this.props.after_sort_key instead * Clear force delete bit after deletion (#2413) * clear force delete bit * clear force delete bit fails * bump to v0.5.15 (#2416) * 2417: Fix mkdocs Travis failure (#2420) * debug * reenable test * Fix SlurmWorkerManager overlaunching (#2391) Co-authored-by: Jing Ge <jingge2@illinois.edu> * Fix accessing worker information from WorkerInfoAccessor (#2419) * Don't fail WorkerManager if a network exception is encountered (#2422) * Rename actionbar => terminal (#2429) * rename actionbar->terminal * remove unused line * Update frontend/src/components/worksheets/Worksheet/Worksheet.js Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> * action bar => terminal in comments Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> * Remove select all for table (#2428) * clear force delete bit * remove select-all checkbox * remove selectAll handler * Remove detach from the frontend (#2427) * clear force delete bit * remove detach from frontend * remove constant * Use GitHub Actions for CI (#2185) for #2094 Based off of Jane's work in https://github.com/candicegjing/codalab-worksheets Time: 40 minutes -> 15-20 minutes Several improvements: Build images split into three parallel steps - rest-server, worker, frontend Tests split into around 10 parallel steps - each step runs about 4 tests, and there is a step which runs the UI tests. If a CLI test gives an error, it archives all Docker containers' logs so that they can be downloaded and inspected. If the UI test gives an error, it archives the screenshot images so that they can be downloaded and inspected. Additionally, the publish to pypi process has changed. Now, publishes to pypi happen on every GitHub release as opposed to every tag push. Effectively, this means that the release workflow has changed a bit: Old workflow: Wait 40 mins for Travis build on master to complete Push a tag to master Wait 40 mins for Travis build on master to complete, which also deploys to pypi New workflow: Wait for GitHub Actions build on master to complete Create a new GitHub release Wait for action to complete, which only deploys to pypi * CI: github.head_ref -> github.ref * CI: properly populate VERSION variable with branch name * Add exit-after-num-runs=1 to slurm worker manager (#2373) Closed via #2289 * Fix showing file contents for record item (#2455) fix #2446 to test: create a schema with a field using files: % schema a % add hello /stdout display bundles in record mode % display record a * Fix long test startup times by using python:3.6.10-slim-buster for default test runs (#2449) Fixes #2388 by using python:3.6.10-slim-buster for default test runs. Following @nelson-liu 's suggestion in #2388 (comment). This image is still around ~40 MB (as opposed to the 5 GB default-cpu image). Time changes from ~20 mins -> 10 mins * Fix github actions on forks by not calling --push (#2457) This conditional expression was in the old `.travis.yml`, but it isn't there in the new github actions workflow. This PR adds that expression so that `--push` is not called from forks. Fixes #2456 * Prettier CLI Reference Doc (#2458) Co-authored-by: Jing Ge <stanford@Stanfords-MacBook-Pro.local> * Actually fix builds from forks by building docker images when needed (#2461) * Test worker restart in GHA (#2466) Resolves #2465 Adding back this test that we used to have in Travis Appended .log for to err log files Co-authored-by: Jing Ge <jingge2@illinois.edu> Co-authored-by: Nelson Liu <nelson-liu@users.noreply.github.com> Co-authored-by: yipenghe <yipenghe@stanford.edu> Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> Co-authored-by: Jing Ge <stanford@Stanfords-MacBook-Pro.local> Co-authored-by: Tony Lee <tonyh.lee@yahoo.com> Co-authored-by: Percy Liang <percyliang@gmail.com>
adiprerepa
pushed a commit
that referenced
this pull request
May 27, 2021
* Fix free disk bytes calculation (#2370) Closed via #2362 * Fix WorkerManager launching (#2372) Co-authored-by: Jing Ge <jingge2@illinois.edu> * Make worker id match output directory and job name (#2369) * Make worker id match output directory and job name * Blacken Co-authored-by: Jing Ge <jingge2@illinois.edu> * Pass down max work dir size and delete workdir on exit to slurm workers (#2354) * Pass down max work dir size and delete workdir on exit to slurm workers * Fix typo. Co-authored-by: Jing Ge <jingge2@illinois.edu> * == -> === (#2357) Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> * Refactor dialogs into worksheetDialog component (#2263) * merge openX to one open dialog variable * refactor error message, delete worksheet message, bundle action fail dialogs into worksheet dialog component * add check when using enter keyword Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> * remove context menu (#2376) * Update print information (#2382) Co-authored-by: Jing Ge <stanford@Stanfords-MacBook-Pro.local> * Add a CLI option to limit the number of jobs allowed to run on a worker (#2289) Closed via #2287 * Set cli verbose default to 0 (#2378) Closed via #2350 * Mounting dependencies on paths specified by keys (#2295) * Fix time displaying issue (#2381) * Fix datetime displaying issue * Add a comment Co-authored-by: Jing Ge <stanford@Stanfords-MacBook-Pro.local> Co-authored-by: yipenghe <yipenghe@stanford.edu> * overdue (#2393) * fix migration (#2403) * Make strings more consistent in terms of terminology / organization (#2409) * tweak dialog prompts * add cut/copied * organize keyboard shortcuts * fix formatting * remove dummy file * ignore a d when a dialog is opened Co-authored-by: yipenghe <yipenghe@stanford.edu> * Replace sacct with scontrol, since sacct is only available on the slurm head node (#2368) * Handle sort key is 0 condition on frontend and use correct sort key for new runs (#2412) * handle sort key is 0 condition * handle sort key is 0 in getAfterSortKey function * use this.props.after_sort_key instead * Clear force delete bit after deletion (#2413) * clear force delete bit * clear force delete bit fails * bump to v0.5.15 (#2416) * 2417: Fix mkdocs Travis failure (#2420) * debug * reenable test * Fix SlurmWorkerManager overlaunching (#2391) Co-authored-by: Jing Ge <jingge2@illinois.edu> * Fix accessing worker information from WorkerInfoAccessor (#2419) * Don't fail WorkerManager if a network exception is encountered (#2422) * Rename actionbar => terminal (#2429) * rename actionbar->terminal * remove unused line * Update frontend/src/components/worksheets/Worksheet/Worksheet.js Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> * action bar => terminal in comments Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> * Remove select all for table (#2428) * clear force delete bit * remove select-all checkbox * remove selectAll handler * Remove detach from the frontend (#2427) * clear force delete bit * remove detach from frontend * remove constant * Use GitHub Actions for CI (#2185) for #2094 Based off of Jane's work in https://github.com/candicegjing/codalab-worksheets Time: 40 minutes -> 15-20 minutes Several improvements: Build images split into three parallel steps - rest-server, worker, frontend Tests split into around 10 parallel steps - each step runs about 4 tests, and there is a step which runs the UI tests. If a CLI test gives an error, it archives all Docker containers' logs so that they can be downloaded and inspected. If the UI test gives an error, it archives the screenshot images so that they can be downloaded and inspected. Additionally, the publish to pypi process has changed. Now, publishes to pypi happen on every GitHub release as opposed to every tag push. Effectively, this means that the release workflow has changed a bit: Old workflow: Wait 40 mins for Travis build on master to complete Push a tag to master Wait 40 mins for Travis build on master to complete, which also deploys to pypi New workflow: Wait for GitHub Actions build on master to complete Create a new GitHub release Wait for action to complete, which only deploys to pypi * CI: github.head_ref -> github.ref * CI: properly populate VERSION variable with branch name * Add exit-after-num-runs=1 to slurm worker manager (#2373) Closed via #2289 * Fix showing file contents for record item (#2455) fix #2446 to test: create a schema with a field using files: % schema a % add hello /stdout display bundles in record mode % display record a * Fix long test startup times by using python:3.6.10-slim-buster for default test runs (#2449) Fixes #2388 by using python:3.6.10-slim-buster for default test runs. Following @nelson-liu 's suggestion in #2388 (comment). This image is still around ~40 MB (as opposed to the 5 GB default-cpu image). Time changes from ~20 mins -> 10 mins * Fix github actions on forks by not calling --push (#2457) This conditional expression was in the old `.travis.yml`, but it isn't there in the new github actions workflow. This PR adds that expression so that `--push` is not called from forks. Fixes #2456 * Prettier CLI Reference Doc (#2458) Co-authored-by: Jing Ge <stanford@Stanfords-MacBook-Pro.local> * Actually fix builds from forks by building docker images when needed (#2461) * Test worker restart in GHA (#2466) Resolves #2465 Adding back this test that we used to have in Travis Appended .log for to err log files Co-authored-by: Jing Ge <jingge2@illinois.edu> Co-authored-by: Nelson Liu <nelson-liu@users.noreply.github.com> Co-authored-by: yipenghe <yipenghe@stanford.edu> Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> Co-authored-by: Jing Ge <stanford@Stanfords-MacBook-Pro.local> Co-authored-by: Tony Lee <tonyh.lee@yahoo.com> Co-authored-by: Percy Liang <percyliang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2417