Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python from 3.6 to 3.7 in codalab docker containers #4109

Merged
merged 5 commits into from May 26, 2022

Conversation

nelson-liu
Copy link
Collaborator

@nelson-liu nelson-liu commented May 25, 2022

Python 3.6 is end-of-life.

I was banging my head trying to figure out why something I was working on in the rest server wasn't working, and it turns out the python version in the docker container was too old. I've upgraded it to 3.7 via conda and moved away from the defunct deadsnakes ppa

this also fixes a very noisy warning in the docker build process about cryptography not supporting 3.6.

@epicfaace epicfaace linked an issue May 25, 2022 that may be closed by this pull request
@epicfaace
Copy link
Member

@nelson-liu great! Can you also update github actions to use python 3.7?

@nelson-liu
Copy link
Collaborator Author

@nelson-liu
Copy link
Collaborator Author

oops, not sure if that link worked, here's a better one: https://github.com/nelson-liu/codalab-worksheets/blob/update_codalab_python/.github/workflows/test.yml#L39

@nelson-liu
Copy link
Collaborator Author

I did the bare minimum here wrt resolving dependencies to make things build / pass, but maybe worth going through and updating other dependencies at some point? anyway, i think this is ready to be looked at @epicfaace

Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

python3.6 -m pip install --no-cache-dir -r requirements.txt;
RUN python3 -m pip install --user --upgrade pip==20.3.4; \
python3 -m pip install setuptools --upgrade; \
python3 -m pip install --no-cache-dir -r requirements.txt;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure that python3 ends up pointing to 3.7, rather than the default system installation of python (3.5?), right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, one of the lines above prepends the conda bin directory to $PATH, which should set the default python.

@epicfaace epicfaace merged commit f2cd9e7 into codalab:master May 26, 2022
@teetone teetone mentioned this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from python 3.6
2 participants