New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python from 3.6 to 3.7 in codalab docker containers #4109
Conversation
@nelson-liu great! Can you also update github actions to use python 3.7? |
should i remove 3.6 from the test matrix as well? https://github.com/codalab/codalab-worksheets/pull/4109/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R39 |
oops, not sure if that link worked, here's a better one: https://github.com/nelson-liu/codalab-worksheets/blob/update_codalab_python/.github/workflows/test.yml#L39 |
I did the bare minimum here wrt resolving dependencies to make things build / pass, but maybe worth going through and updating other dependencies at some point? anyway, i think this is ready to be looked at @epicfaace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
python3.6 -m pip install --no-cache-dir -r requirements.txt; | ||
RUN python3 -m pip install --user --upgrade pip==20.3.4; \ | ||
python3 -m pip install setuptools --upgrade; \ | ||
python3 -m pip install --no-cache-dir -r requirements.txt; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure that python3 ends up pointing to 3.7, rather than the default system installation of python (3.5?), right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, one of the lines above prepends the conda bin
directory to $PATH, which should set the default python.
Python 3.6 is end-of-life.
I was banging my head trying to figure out why something I was working on in the rest server wasn't working, and it turns out the python version in the docker container was too old. I've upgraded it to 3.7 via conda and moved away from the defunct deadsnakes ppa
this also fixes a very noisy warning in the docker build process about
cryptography
not supporting 3.6.