Replace google.com with recaptcha.net #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percyliang
approved these changes
Oct 19, 2022
epicfaace
requested changes
Oct 25, 2022
| @@ -78,7 +78,7 @@ def do_signup(): | |||
| if not token: | |||
| errors.append('Google reCAPTCHA token is missing.') | |||
| else: | |||
| url = 'https://www.google.com/recaptcha/api/siteverify' | |||
| url = 'https://www.recaptcha.net/recaptcha/api/siteverify' | |||
There was a problem hiding this comment.
What is https://www.recaptcha.net? Do you have an info page on what it's used for / who runs it / how it uses data?
There was a problem hiding this comment.
Oh I found it, it's google. Can you link to https://developers.google.com/recaptcha/docs/faq#can-i-use-recaptcha-globally in the comments?
epicfaace
approved these changes
Oct 25, 2022
| @@ -78,7 +78,7 @@ def do_signup(): | |||
| if not token: | |||
| errors.append('Google reCAPTCHA token is missing.') | |||
| else: | |||
| url = 'https://www.google.com/recaptcha/api/siteverify' | |||
| url = 'https://www.recaptcha.net/recaptcha/api/siteverify' | |||
There was a problem hiding this comment.
Oh I found it, it's google. Can you link to https://developers.google.com/recaptcha/docs/faq#can-i-use-recaptcha-globally in the comments?
|
I'll rebase this branch. |
yifanmai
force-pushed
the
yifanmai/3698-recaptcha
branch
from
14cd4e8
to
a865b4f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
This allows reCaptcha to be usable from within China. Refer to the reCaptcha documentation.
Related issues
Screenshots
Accounts page is unchanged.
Checklist