Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/4263 update slurm #4288

Merged
merged 11 commits into from
Nov 7, 2022
Merged

Fix/4263 update slurm #4288

merged 11 commits into from
Nov 7, 2022

Conversation

AndrewJGaut
Copy link
Contributor

Reasons for making this change

The Slurm instance used by Stanford got updated and people with multiple account affiliations need to specify an account with which to run a Slurm batch job. This PR fixes that issue so that these users can still launch a worker manager with nlp-cl-worker-manager.

Related issues

#4261, #4263

@AndrewJGaut AndrewJGaut marked this pull request as ready for review November 7, 2022 17:06
Copy link
Collaborator

@teetone teetone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Verified it works:

cl-workers

@AndrewJGaut AndrewJGaut merged commit e73cc65 into master Nov 7, 2022
@AndrewJGaut AndrewJGaut deleted the fix/4263-update-slurm branch November 7, 2022 17:56
@leilenah leilenah mentioned this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants