Add error handle code for stale file handler when cl upload
#4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwjn
changed the title
cl upload
|
Since this part of code is running by local CLI, and I can not create a stale file handler using local PC. Will keep an eye on this and test it out when CL version is updated. |
percyliang
reviewed
Nov 7, 2022
| if ignore_nonexistent_path: | ||
| # If we have trouble list the dir, return the size of this path as 0 | ||
| # Do not raise error and just ignore the stale file handler/ | ||
| return 0 |
There was a problem hiding this comment.
Could this potentially suppress other errors? Maybe worth printing out a warning at least (assuming it doesn't result in too much output)?
There was a problem hiding this comment.
Thank you! I will add a Warning print with the path, and test it out using the dev environment before getting it merged.
percyliang
reviewed
Nov 7, 2022
percyliang
approved these changes
Nov 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
When uploading from nlp machine, we might meet stale file handler(https://www.baeldung.com/linux/stale-file-handles) generated by other process. Add some code to just ignore those stale file handlers.
For stale file handlers, we can not even
lsthem.Related issues
Screenshots
Checklist