Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes to track disk quota usage #4307

Merged
merged 61 commits into from
Apr 5, 2023

Conversation

AndrewJGaut
Copy link
Contributor

Reasons for making this change

We want to ensure that disk quota usage can be tracked for running bundles so that attackers can't zip bomb the system.

Related issues

Resolves issue #4298

@epicfaace
Copy link
Member

@AndrewJGaut what's the status of this PR?

@AndrewJGaut
Copy link
Contributor Author

@AndrewJGaut what's the status of this PR?

Haven't had time to get to it. The current Actions run is failing because of a hasty change I made, but if you look at this prior one (https://github.com/codalab/codalab-worksheets/actions/runs/4171333091/jobs/7491776164) it almost worked. The only thing is I think there's a race condition that I've been trying to fix but have been unsuccessful thus far. I don't think the issue really has to do with Kubernetes.

@epicfaace
Copy link
Member

@AndrewJGaut good to merge this now?

@AndrewJGaut
Copy link
Contributor Author

@AndrewJGaut good to merge this now?

I was going to mention this in meeting today, but we could merge now or we could do one more quick review (since I made some changes since last review). I think it's OK either way

@AndrewJGaut
Copy link
Contributor Author

@AndrewJGaut good to merge this now?

I was going to mention this in meeting today, but we could merge now or we could do one more quick review (since I made some changes since last review). I think it's OK either way

In meeting, we decided to merge this now.

@AndrewJGaut AndrewJGaut merged commit b0d2857 into master Apr 5, 2023
68 checks passed
@AndrewJGaut AndrewJGaut deleted the fix/4298-check-running-disk-quota branch April 5, 2023 22:09
@epicfaace epicfaace mentioned this pull request Apr 19, 2023
@AndrewJGaut AndrewJGaut mentioned this pull request May 18, 2023
@epicfaace epicfaace mentioned this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants