Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ".edu.cn" accounts to have more time and disk quota #4440

Merged
merged 9 commits into from
Apr 19, 2023
Merged

Conversation

wwwjn
Copy link
Contributor

@wwwjn wwwjn commented Apr 7, 2023

Reasons for making this change

Allow ".edu.cn" accounts to have more time and disk quota

Related issues

None

Screenshots

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@wwwjn wwwjn requested a review from epicfaace April 7, 2023 03:29
codalab/lib/spec_util.py Outdated Show resolved Hide resolved
codalab/model/bundle_model.py Outdated Show resolved Hide resolved
codalab/model/bundle_model.py Show resolved Hide resolved
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also include ".ac.xx" domains -- see https://en.wikipedia.org/wiki/.ac_(second-level_domain)

@wwwjn
Copy link
Contributor Author

wwwjn commented Apr 12, 2023

We should also include ".ac.xx" domains -- see https://en.wikipedia.org/wiki/.ac_(second-level_domain)

That's a good catch!

@wwwjn wwwjn self-assigned this Apr 12, 2023
@mergify mergify bot merged commit 1afbca8 into master Apr 19, 2023
70 checks passed
@mergify mergify bot deleted the fix-edu branch April 19, 2023 19:59
@epicfaace epicfaace mentioned this pull request Apr 19, 2023
@epicfaace epicfaace mentioned this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants