Provides an option not to ignore patterns like .git, hidden files and… #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… MACOSX files. Needed for the blob storage migration, because once upon a time these files were uploaded to bundles. Omitting them will cause discrepancy in bundles after the migration.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
AndrewJGaut
requested changes
Nov 22, 2023
There was a problem hiding this comment.
This looks GREAT! Only thing is can we do the same thing for zip_directory here if possible? After that change, I think this is definitely good to go. Love the code styling for the test, too -- it's super clean!
|
Done. zip_directory appears to be dead code, but updated it to avoid confusion. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… MACOSX files.
Reasons for making this change
Needed for the blob storage migration, because once upon a time these files were uploaded as part of bundles. Omitting them will cause discrepancy in bundles after the migration.
Related issues
fixes #4575
Checklist