Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcodes the golden data path. #4588

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Hardcodes the golden data path. #4588

merged 1 commit into from
Jan 27, 2024

Conversation

HidyHan
Copy link
Contributor

@HidyHan HidyHan commented Jan 25, 2024

Reasons for making this change

Chrome has changed its browser name to chrome-headless-shell which is part of the golden data directory. Our golden data is stored in path chrome/. For now, hard code the golden data path.

Related issues

Screenshots

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@wwwjn wwwjn merged commit 345c37e into master Jan 27, 2024
63 checks passed
@wwwjn wwwjn deleted the ui branch January 27, 2024 08:01
@wwwjn wwwjn mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants