Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor unit testing #94

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Refactor unit testing #94

merged 3 commits into from
Mar 3, 2023

Conversation

JellevanKraaij
Copy link
Contributor

Testing

  • improve naming by adding prefix to Cmake
  • create test fixture for a basic window

Workflow

  • removed workflow_dispatch as it should 🙏 not change anything on its own

@JellevanKraaij
refacture testing
9475c04 
- improve naming by adding prefix to Cmake
- create test fixture for a basic window
@JellevanKraaij
remove unnecessary workflow_dispatch
33a646b
@JellevanKraaij
Copy link
Contributor Author

Did I totally break the workflow by removing workflow_dispatch?
Maybe the settings of when a workflow is allowed to run is changed? @W2Wizard maybe you need to approve it?
Otherwise, I guess the workflow_dispatch is somehow bugging the run... and i will change it back in that case 😕

@W2Wizard
Copy link
Collaborator

W2Wizard commented Mar 3, 2023

Lol, it just doesn't run ? Usually the workflow_dispatch is for manual execution.

W2Wizard
W2Wizard reviewed Mar 3, 2023
View reviewed changes
tests/WindowFixture.hpp Outdated Show resolved Hide resolved
@JellevanKraaij
Copy link
Contributor Author

the workflow dispatch should not make a difference

@W2Wizard W2Wizard added the Improvement Adds an implementation or improves on something label Mar 3, 2023
@W2Wizard
Copy link
Collaborator

W2Wizard commented Mar 3, 2023

the workflow dispatch should not make a difference

Yeah makes no sense, but it's not even detecting the workflow thing to begin with 😕

@JellevanKraaij
Copy link
Contributor Author

JellevanKraaij commented Mar 3, 2023 •
edited
Loading

https://www.githubstatus.com/incidents/qfby3shb6r3w
guess GitHub made a small error

@W2Wizard
Copy link
Collaborator

W2Wizard commented Mar 3, 2023

https://www.githubstatus.com/incidents/qfby3shb6r3w guess GitHub made a small error

RIP to the intern who broke it 😢

@W2Wizard W2Wizard merged commit 73dafec into codam-coding-college:master Mar 3, 2023
@Lacusch Lacusch mentioned this pull request Mar 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W2Wizard W2Wizard W2Wizard approved these changes

Assignees
No one assigned
Labels
Improvement Adds an implementation or improves on something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JellevanKraaij @W2Wizard