Improve container detection in Rootline::determineContentElement #6
Assignees
Comments
justusmoroni
pushed a commit
that referenced
this issue
Apr 3, 2024
Before we checked if a CType contained a specific string to check if it is a container. This was open to false positives if a normal content element also contained this string. We now check the proper place to detect if a CType is registered as a container. Related: #6
justusmoroni
pushed a commit
that referenced
this issue
Apr 3, 2024
Before we checked if a CType contained a specific string to check if it is a container. This was open to false positives if a normal content element also contained this string. We now check the proper place to detect if a CType is registered as a container. Related: #6
justusmoroni
added a commit
that referenced
this issue
Apr 3, 2024
Before we checked if a CType contained a specific string to check if it is a container. This was open to false positives if a normal content element also contained this string. We now check the proper place to detect if a CType is registered as a container. Related: #6 Co-authored-by: Justus Moroni <justus.moroni@codappix.com>
|
Will be included in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently look if the CType contains
_container-.We need to improve this and see if we can register the containers in an array.
This way we don't have to look in the CType for
_container-as some developers could just not include this in their container CTypes.The text was updated successfully, but these errors were encountered: