Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is introducing changes that simplify controller creation.
1. Simpler controller definition
Note that it is not mandatory to use a class which extends the
Controller
base. Oneimport
statement less.2. Functional controllers
The main benefit is that
this
is not required for accessing the store in the controller. Knowingthis
upfront opens more possibilites.2.1. Declaration of store references
This is similar to the concept explained in #347.
Another potential benefit of this approach is that references could be typed in TypeScript.
The question remains how to use references in triggers and computables.
2.2. Store method aliasing
Would be even cooler if
get
,set
and other methods are passed alongsidestore
.