Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ascii folder names are not supported #13

Closed
beaussan opened this issue Mar 20, 2022 · 5 comments
Closed

Non-ascii folder names are not supported #13

beaussan opened this issue Mar 20, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@beaussan
Copy link

Hi,

I have emoji in my folder names (in order to replicate notion's folder icons), and from some initial testing, there seems to be some issue with that :

GET on /vault/filename

Yield to the following error in the obsidian console :
node:internal/errors:464 Uncaught (in promise) TypeError: Invalid character in header content ["Content-Disposition"]

GET on /periodic/period

Yield the following error in the obsidian console :
TypeError: Invalid character in header content ["Content-Location"]


All request were done on the provided swagger UI, and all requests hangs instead of returning a 500 error, maybe that can also be a improvement ?

And I want to say, I love the idea of the plugin, there is soo much potential to be plugged to external tools, but since nearly all of my files are in a folder that contains a emoji name, I'm not able to use this plugin

@coddingtonbear coddingtonbear added the bug Something isn't working label Mar 22, 2022
@coddingtonbear coddingtonbear changed the title support emoji in folder names Non-ascii folder names are not supported Apr 26, 2022
@beaussan
Copy link
Author

beaussan commented Apr 26, 2022

Thanks for fixing the first one (/vault/filename), however the one with the content-location header still breaks, maybe applying the same escape system ? (here should do the trick )

Reproduction :
GET /periodic/daily
With a folder name "🖊️ journal/"

Workaround : using the /vault/filename works

I can open a PR if you want

@coddingtonbear
Copy link
Owner

Ok; this might be fixed in a27c603 now (release 1.3.5); if it's not, I'm afraid I might need you to post a pull request.

@beaussan
Copy link
Author

It works perfectly !! 🎉 Thank you a lot !
Now I can experiment to create workflow using the api ❤️

@ngirard
Copy link

ngirard commented Apr 27, 2022

Now I can experiment to create workflow using the api

This tickles my curiosity... would you mind expanding on that ? Cheers !

@beaussan
Copy link
Author

This tickles my curiosity... would you mind expanding on that ?
Yes, some of my plans includes

  • Making a api (using something like n8n + postgresql as a buffer) to be able to programmaticaly insert in my vault's workbench from webhooks / external apis
  • Extracting metrics from my daily notes (from the dataview keys in the files) into a external dashboard
  • Keeping in one way - or maybe two way sync - between obsidian and a external tool (like notion) for teams

I could use the filesystem for all of this, but it makes it easier it easier to do in a distributed manner (as in I can have a full time running server to receive the webhooks and then do pulling after it's stored once Obsidian is up)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants