Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm/Delete a TODO comment on stake lockup period in StakeLocker.sol #40

Closed
code423n4 opened this issue Apr 19, 2021 · 1 comment
Closed

Confirm/Delete a TODO comment on stake lockup period in StakeLocker.sol #40

code423n4 opened this issue Apr 19, 2021 · 1 comment
Labels
bug Something isn't working disagree with severity invalid sponsor acknowledged

Comments

@code423n4
Copy link
Contributor

Handle

0xRajeev

Vulnerability details

Impact

The below comment on the stake lockup period (L52 in StakeLocker.sol constructor) indicates that the default value has not been confirmed:

lockupPeriod = 180 days; // TODO: Confirm default

Proof of Concept

https://github.com/maple-labs/maple-core/blob/355141befa89c7623150a83b7d56a5f5820819e9/contracts/StakeLocker.sol#L52

Tools Used

Manual Analysis

Recommended Mitigation Steps

Confirm the correct default value and delete the TODO comment on stake lockup period.
@code423n4 code423n4 added 1 (Low Risk) bug Something isn't working labels Apr 19, 2021
code423n4 added a commit that referenced this issue Apr 19, 2021
@code423n4
0xRajeev issue #40
a7f61bf
@lucas-manuel
Copy link
Collaborator

We are aware of TODOs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working disagree with severity invalid sponsor acknowledged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Arachnid @lucas-manuel @code423n4