Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sortArray optimizable #19

Open
code423n4 opened this issue Apr 25, 2021 · 1 comment
Open

sortArray optimizable #19

code423n4 opened this issue Apr 25, 2021 · 1 comment
Labels
bug Something isn't working G (Gas Optimization)

Comments

@code423n4
Copy link
Collaborator

Handle

gpersoon

Vulnerability details

Impact

The function sortArray is only called by getAnchorPrice() in Router.sol
Then it is only used to get the second element of the sorted array.
With this knowledge it is possible to write a function that is more efficient.
Sort functions are relative expensive functions.

Proof of Concept

Router.sol:
function getAnchorPrice() public view returns (uint anchorPrice) {
....
uint[] memory _sortedAnchorFeed = iUTILS(UTILS()).sortArray(arrayPrices);
anchorPrice = _sortedAnchorFeed[2];

Tools Used

Recommended Mitigation Steps

Make a partial sort function that only returns the required value

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Apr 25, 2021
code423n4 added a commit that referenced this issue Apr 25, 2021
@strictly-scarce
Copy link
Collaborator

Do you have an example of how to make it better? It's already pretty good for what it does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

2 participants