New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

borrowingFee is not initialized #47

Closed

code423n4 opened this issue Jun 2, 2021 · 1 comment

Labels

1 (Low Risk) bug sponsor disputed

Contributor

code423n4 commented Jun 2, 2021

Handle

0xRajeev

Vulnerability details

Impact

borrowingFee not initialized (defaults to 0) at declaration and depends on setFee() for a non-zero acceptable value.

It is safer to initialize at declaration to a non-zero default otherwise borrowers can borrow for zero fees.

Proof of Concept

https://github.com/code-423n4/2021-05-yield/blob/e4c8491cd7bfa5dc1b59eb1b257161cd5bf8c6b0/contracts/LadleStorage.sol#L37

https://github.com/code-423n4/2021-05-yield/blob/e4c8491cd7bfa5dc1b59eb1b257161cd5bf8c6b0/contracts/Ladle.sol#L304

https://github.com/code-423n4/2021-05-yield/blob/e4c8491cd7bfa5dc1b59eb1b257161cd5bf8c6b0/contracts/Ladle.sol#L438

https://github.com/code-423n4/2021-05-yield/blob/e4c8491cd7bfa5dc1b59eb1b257161cd5bf8c6b0/contracts/Ladle.sol#L105-L112

Tools Used

Manual Analysis

Recommended Mitigation Steps

Initialize borrowingFee at declaration to a non-zero default
Add a threshold check for the same in setFee()

code423n4 added 1 (Low Risk) bug labels

code423n4 added a commit that referenced this issue


          0xRajeev issue #47

5542f52

alcueca added the sponsor disputed label

Collaborator

alcueca commented Jun 2, 2021

We intend to go live with zero fee borrowing.

dmvt closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment