Skip to content

Issues: code-423n4/2021-07-connext-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

36 Open 41 Closed
36 Open 41 Closed
Author
Filter by author
Label
Filter by label
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Milestones
Filter by milestone
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Cache storage variables to local variables to save gas bug Something isn't working G (Gas Optimization) sponsor confirmed Yes, this is a problem and we intend to fix it.
#75 opened Jul 12, 2021 by code423n4
@sanchaymittal
1
Use the unchecked keyword to save gas bug Something isn't working G (Gas Optimization) sponsor confirmed Yes, this is a problem and we intend to fix it.
#74 opened Jul 12, 2021 by code423n4
@sanchaymittal
1
Deflationary and fee-on-transfer tokens are not correctly accounted 1 (Low Risk) bug Something isn't working sponsor confirmed Yes, this is a problem and we intend to fix it.
#68 opened Jul 12, 2021 by code423n4
@LayneHaber
1
Unchangeable chain ID information 1 (Low Risk) bug Something isn't working sponsor acknowledged Yes, technically the issue is correct, but we are not going to resolve it for xyz reasons.
#66 opened Jul 12, 2021 by code423n4
1
Increment in the loop can be made unchecked bug Something isn't working G (Gas Optimization) sponsor acknowledged Yes, technically the issue is correct, but we are not going to resolve it for xyz reasons.
#65 opened Jul 12, 2021 by code423n4
1
Missing @param in fulfill NatSpec 0 (Non-critical) bug Something isn't working sponsor confirmed Yes, this is a problem and we intend to fix it.
#64 opened Jul 11, 2021 by code423n4
@LayneHaber
1
Optimizing the for loop bug Something isn't working G (Gas Optimization) sponsor acknowledged Yes, technically the issue is correct, but we are not going to resolve it for xyz reasons.
#60 opened Jul 11, 2021 by code423n4
1
Revert strings bug Something isn't working G (Gas Optimization) sponsor confirmed Yes, this is a problem and we intend to fix it.
#59 opened Jul 11, 2021 by code423n4
@sanchaymittal
1
Relayer txs can be frontrunned 1 (Low Risk) bug Something isn't working sponsor acknowledged Yes, technically the issue is correct, but we are not going to resolve it for xyz reasons.
#58 opened Jul 11, 2021 by code423n4
2
Don't ask for the user's signature when msg.sender == txData.user 0 (Non-critical) bug Something isn't working sponsor confirmed Yes, this is a problem and we intend to fix it.
#57 opened Jul 11, 2021 by code423n4
@LayneHaber
1
Refacotr: Reuse same code for hashVariantTransactionData with txData and when preparedBlockNumber is 0 0 (Non-critical) bug Something isn't working sponsor confirmed Yes, this is a problem and we intend to fix it.
#56 opened Jul 11, 2021 by code423n4
@LayneHaber
1
Signatures use only tx ID instead of entire digest 2 (Med Risk) bug Something isn't working sponsor acknowledged Yes, technically the issue is correct, but we are not going to resolve it for xyz reasons.
#54 opened Jul 11, 2021 by code423n4
2
An attacker can front-run a user’s prepare() tx on sending chain to cause DoS by griefing 1 (Low Risk) bug Something isn't working sponsor acknowledged Yes, technically the issue is correct, but we are not going to resolve it for xyz reasons.
#52 opened Jul 11, 2021 by code423n4
@LayneHaber
2
Missing zero-address checks 1 (Low Risk) bug Something isn't working sponsor confirmed Yes, this is a problem and we intend to fix it.
#50 opened Jul 11, 2021 by code423n4
@sanchaymittal
1
Lack of guarded launch approach may be risky 1 (Low Risk) bug Something isn't working sponsor confirmed Yes, this is a problem and we intend to fix it.
#49 opened Jul 11, 2021 by code423n4
@LayneHaber
1
Anyone can arbitrarily add router liquidity 3 (High Risk) bug Something isn't working sponsor acknowledged Yes, technically the issue is correct, but we are not going to resolve it for xyz reasons.
#48 opened Jul 11, 2021 by code423n4
2
Expired transfers will lock user funds on the sending chain 3 (High Risk) bug Something isn't working sponsor confirmed Yes, this is a problem and we intend to fix it.
#47 opened Jul 11, 2021 by code423n4
@LayneHaber
1
Router liquidity on receiving chain can be double-dipped by the user 3 (High Risk) bug Something isn't working sponsor confirmed Yes, this is a problem and we intend to fix it.
#46 opened Jul 11, 2021 by code423n4
@LayneHaber
1
Checking non-zero value can avoid an external call to save gas bug Something isn't working G (Gas Optimization) sponsor confirmed Yes, this is a problem and we intend to fix it.
#45 opened Jul 11, 2021 by code423n4
@sanchaymittal
1
Evaluate security benefit vs gas usage trade-off for using nonreentrant modifier on different functions bug Something isn't working G (Gas Optimization) sponsor confirmed Yes, this is a problem and we intend to fix it.
#43 opened Jul 11, 2021 by code423n4
@LayneHaber
1
Consolidating library functions can save gas by preventing external calls bug Something isn't working G (Gas Optimization) sponsor confirmed Yes, this is a problem and we intend to fix it.
#42 opened Jul 11, 2021 by code423n4
@LayneHaber
1
Checking before external library call can save 2600 gas bug Something isn't working G (Gas Optimization) sponsor confirmed Yes, this is a problem and we intend to fix it.
#41 opened Jul 11, 2021 by code423n4
@LayneHaber
1
Using access lists can save gas due to EIP-2930 post-Berlin hard fork bug Something isn't working G (Gas Optimization) sponsor confirmed Yes, this is a problem and we intend to fix it.
#39 opened Jul 11, 2021 by code423n4
@LayneHaber
1
Assignment of variables not needed bug Something isn't working G (Gas Optimization) sponsor acknowledged Yes, technically the issue is correct, but we are not going to resolve it for xyz reasons.
#36 opened Jul 11, 2021 by code423n4
1
MAX_TIMEOUT 1 (Low Risk) bug Something isn't working sponsor confirmed Yes, this is a problem and we intend to fix it.
#33 opened Jul 11, 2021 by code423n4
@sanchaymittal
1
ProTip! Adding no:label will show everything without a label.