Skip to content

Issues: code-423n4/2021-07-sherlock-findings

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

96 Open 54 Closed
96 Open 54 Closed
Author
Filter by author
Label
Filter by label
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Milestones
Filter by milestone
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Saving gas by checking the last-recorded block number bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor confirmed issue
#150 opened Jul 30, 2021 by code423n4
1
Avoid repeating storage reads in a loop to save gas bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor confirmed issue
#149 opened Jul 30, 2021 by code423n4
1
Gas optimization on calculating the storage slot of a token bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor confirmed issue
#148 opened Jul 30, 2021 by code423n4
User's calcUnderlyingInStoredUSD value is underestimated 1 (Low Risk) bug Something isn't working disagree with severity sponsor confirmed Sponsor confirmed issue
#144 opened Jul 30, 2021 by code423n4
2
Tokens cannot be reinitialized with new lock tokens 1 (Low Risk) bug Something isn't working sponsor acknowledged Sponsor acknowledged, but not resolving
#141 opened Jul 30, 2021 by code423n4
1
Cannot set watsonsSherxWeight to the maximum 1 (Low Risk) bug Something isn't working invalid This doesn't seem right sponsor disputed Sponsor was not able to duplicate or disagrees
#140 opened Jul 30, 2021 by code423n4
2
Inconsistent block number comparison when deciding an unstaking entry is active 1 (Low Risk) bug Something isn't working sponsor confirmed Sponsor confirmed issue
#139 opened Jul 30, 2021 by code423n4
Possible divide-by-zero error in PoolBase 1 (Low Risk) bug Something isn't working sponsor confirmed Sponsor confirmed issue
#136 opened Jul 30, 2021 by code423n4
Missing non-zero address checks 1 (Low Risk) bug Something isn't working sponsor acknowledged Sponsor acknowledged, but not resolving
#135 opened Jul 30, 2021 by code423n4
1
SafeMath library is not always used in PoolBase 1 (Low Risk) bug Something isn't working sponsor acknowledged Sponsor acknowledged, but not resolving
#133 opened Jul 30, 2021 by code423n4
order of operations in Payout.sol 1 (Low Risk) bug Something isn't working invalid This doesn't seem right sponsor disputed Sponsor was not able to duplicate or disagrees
#130 opened Jul 29, 2021 by code423n4
2
Confusing exponentiation (10e17) 0 (Non-critical) bug Something isn't working sponsor confirmed Sponsor confirmed issue
#129 opened Jul 28, 2021 by code423n4
1
Uncheckable math in redeem() bug Something isn't working G (Gas Optimization) sponsor acknowledged Sponsor acknowledged, but not resolving
#127 opened Jul 28, 2021 by code423n4
1
uncheckable math in payout() bug Something isn't working G (Gas Optimization) sponsor acknowledged Sponsor acknowledged, but not resolving
#126 opened Jul 28, 2021 by code423n4
1
NatSpec typo in _doSherX @return 0 (Non-critical) bug Something isn't working sponsor confirmed Sponsor confirmed issue
#125 opened Jul 28, 2021 by code423n4
1
gas reduction in calcUnderlying bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor confirmed issue
#124 opened Jul 28, 2021 by code423n4
1
Poorly Named variables 0 (Non-critical) bug Something isn't working disagree with severity sponsor confirmed Sponsor confirmed issue
#123 opened Jul 28, 2021 by code423n4
3
Unused functions and storage cost gas. bug Something isn't working G (Gas Optimization) sponsor acknowledged Sponsor acknowledged, but not resolving
#120 opened Jul 28, 2021 by code423n4
1
Single under-funded protocol can break paying off debt 3 (High Risk) bug Something isn't working sponsor acknowledged Sponsor acknowledged, but not resolving
#119 opened Jul 28, 2021 by code423n4
1
ERC20 can accidentally burn tokens 1 (Low Risk) bug Something isn't working sponsor acknowledged Sponsor acknowledged, but not resolving
#118 opened Jul 28, 2021 by code423n4
1
ERC20 non-standard names 1 (Low Risk) bug Something isn't working disagree with severity sponsor confirmed Sponsor confirmed issue
#117 opened Jul 28, 2021 by code423n4
3
initializeSherXERC20 can be called more than once 1 (Low Risk) bug Something isn't working sponsor confirmed Sponsor confirmed issue
#116 opened Jul 28, 2021 by code423n4
Sanitize _weights in setWeights on every use 1 (Low Risk) bug Something isn't working sponsor confirmed Sponsor confirmed issue
#115 opened Jul 28, 2021 by code423n4
1
Anyone can unstake on behalf of someone 1 (Low Risk) bug Something isn't working sponsor confirmed Sponsor confirmed issue
#114 opened Jul 28, 2021 by code423n4
[Gas optimizations] - Public functions that are public, but could be external bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor confirmed issue
#112 opened Jul 28, 2021 by code423n4
ProTip! no:milestone will show everything without a milestone.