Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of emission of event when changing dao fees #215

Open
code423n4 opened this issue Jul 21, 2021 · 1 comment
Open

Lack of emission of event when changing dao fees #215

code423n4 opened this issue Jul 21, 2021 · 1 comment
Assignees
@verifyfirst
Labels
0 (Non-critical) bug Something isn't working sponsor acknowledged

Comments

@code423n4
Copy link
Contributor

Handle

JMukesh

Vulnerability details

Impact

event should be emitted after the sensitive action like updating fees, to track off-chain changes

Proof of Concept

https://github.com/code-423n4/2021-07-spartan/blob/e2555aab44d9760fdd640df9095b7235b70f035e/contracts/Dao.sol#L128

Tools Used

manual review

Recommended Mitigation Steps

Emit an event for critical parameter changes.
@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Jul 21, 2021
code423n4 added a commit that referenced this issue Jul 21, 2021
@code423n4
JMukesh issue #215
315daec
@verifyfirst
Copy link
Collaborator

Genesis factors are intended to be called only once - we consider events to be used on regular actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verifyfirst verifyfirst

Labels
0 (Non-critical) bug Something isn't working sponsor acknowledged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@verifyfirst @code423n4