Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool.sol + Router.sol: Set revenue directly as _fee #56

Open
code423n4 opened this issue Jul 18, 2021 · 0 comments
Open

Pool.sol + Router.sol: Set revenue directly as _fee #56

code423n4 opened this issue Jul 18, 2021 · 0 comments
Assignees

Comments

@code423n4
Copy link
Contributor

Handle

hickuphh3

Vulnerability details

Impact

// Pool.sol: L344-345
map30DPoolRevenue = 0;
map30DPoolRevenue = map30DPoolRevenue+(_fee);

// Router.sol: L317-318
mapAddress_30DayDividends[_pool] = 0;
mapAddress_30DayDividends[_pool] = mapAddress_30DayDividends[_pool] + _fees;

can simply be written as

map30DPoolRevenue = _fee;

mapAddress_30DayDividends[_pool] = _fees;

respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants