Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dao.sol: Define BASE as iBEP20 instead of address #60

Open
code423n4 opened this issue Jul 19, 2021 · 0 comments
Open

Dao.sol: Define BASE as iBEP20 instead of address #60

code423n4 opened this issue Jul 19, 2021 · 0 comments
Assignees

Comments

@code423n4
Copy link
Contributor

Handle

hickuphh3

Vulnerability details

Impact

BASE is defined as an address type, but is casted as iBEP20 in almost every instance within the Dao contract, and in numerous instances in many other contracts as well. It would therefore be better to define it as iBEP20 instead, to avoid casting.

Recommended Mitigation Steps

Change address public BASE; to iBEP public BASE. Castings of BASE to iBEP20 can be removed subsequently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants