Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas optimization: no need for extra variable declaration #7

Open
code423n4 opened this issue Sep 6, 2021 · 0 comments
Open

Gas optimization: no need for extra variable declaration #7

code423n4 opened this issue Sep 6, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged

Comments

@code423n4
Copy link
Contributor

Handle

tensors

Vulnerability details

Impact

Not declaring a variable can save gas.

Proof of Concept

https://github.com/code-423n4/2021-09-bvecvx/blob/1d64bd58c7a4224cc330cef283561e90ae6a3cf5/veCVX/contracts/locker/CvxLocker.sol#L354

Since the locksLength variable isn't used often, you can save gas by omitting it.

Recommended Mitigation Steps

Use locks.length instead.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Sep 6, 2021
code423n4 added a commit that referenced this issue Sep 6, 2021
@code423n4
tensors issue #7
e79354c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@C2tP-C2tP @code423n4