Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TridentNFT.permitAll prviliges discrepancy for operator #45

Open
code423n4 opened this issue Oct 6, 2021 · 0 comments
Open

TridentNFT.permitAll prviliges discrepancy for operator #45

code423n4 opened this issue Oct 6, 2021 · 0 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Warden finding sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The TridentNFT.permitAll function allows the operator (isApprovedForAll[owner][recoveredAddress]) to change the operator (and lock themself out).
The same functionality without permits does not work as setApprovalForAll requires the owner authority.

Impact

permitAll should have the same auth checks as setApprovalForAll and not allow the operator to change the operator.

Recommended Mitigation Steps

Remove the || isApprovedForAll[owner][recoveredAddress] from the require statement.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Warden finding labels Oct 6, 2021
code423n4 added a commit that referenced this issue Oct 6, 2021
@code423n4
cmichel issue #45
d8b647e
@sarangparikh22 sarangparikh22 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 5, 2021
@CloudEllie CloudEllie reopened this Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Warden finding sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sarangparikh22 @code423n4 @CloudEllie