Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be aware that transactions can be frontrun to exactly the estimated amount. #153

Open
code423n4 opened this issue Sep 16, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Warden finding duplicate Another warden found this issue

Comments

@code423n4
Copy link
Contributor

Handle

tensors

Vulnerability details

##Impact
The developer should be aware that in many cases where it is profitable, MEV bots will frontrun
the transactions until the output amount is exactly the expected amount, giving the worst execution possible.
In this case, if the expected amount is too low, the protocl losses funds.

##Recommendations
The developer should keep in mind that the expected amount is the lower bound, and setting it too low will result in a loss of funds in most cases. When manually inputting transactions, do not ignore this fact.

@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Warden finding labels Sep 16, 2021
code423n4 added a commit that referenced this issue Sep 16, 2021
@GainsGoblin GainsGoblin added the duplicate Another warden found this issue label Oct 4, 2021
@GalloDaSballo
Copy link
Collaborator

Agree with the finding, would like code link and example rather than vague statement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Warden finding duplicate Another warden found this issue
Projects
None yet
Development

No branches or pull requests

3 participants