Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused imports #89

Open
code423n4 opened this issue Sep 15, 2021 · 2 comments
Open

Unused imports #89

code423n4 opened this issue Sep 15, 2021 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Warden finding sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

There are unused imports. They will increase the size of deployment with no real benefit. An example of such an import is: import "../interfaces/IVault.sol"; in Controller or import "../interfaces/IController.sol"; in LegacyController.

Recommended Mitigation Steps

Consider removing unused imports to save some gas.
code423n4 added a commit that referenced this issue Sep 15, 2021
@code423n4
pauliax issue #89
dc1eff2
@Haz077 Haz077 added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Sep 25, 2021
@uN2RVw5q
Copy link
Collaborator

uN2RVw5q commented Sep 27, 2021 •
edited

They will increase the size of deployment

This is incorrect. An unused import will not affect the deployment cost of a contract. I would not consider this to be a gas-optimization. Maybe style or code quality.

@GalloDaSballo GalloDaSballo added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed G (Gas Optimization) labels Oct 12, 2021
@GalloDaSballo
Copy link
Collaborator

Agree with sponsor that finding is non-critical code-style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Warden finding sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GalloDaSballo @code423n4 @Haz077 @uN2RVw5q