New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Saving by changing the visibility of initialize function from public to external #3

Open

code423n4 opened this issue Oct 28, 2021 · 1 comment

Labels

bug G (Gas Optimization)

Contributor

code423n4 commented Oct 28, 2021

Handle

jah

Vulnerability details

Impact

public functions that are never called by the contract should be declared external to save gas.

Proof of Concept

https://github.com/code-423n4/2021-10-badgerdao/blob/9c0ea7b3b02675211446f6c81750c5f3c0a86370/contracts/WrappedIbbtc.sol#L91
https://github.com/code-423n4/2021-10-badgerdao/blob/9c0ea7b3b02675211446f6c81750c5f3c0a86370/contracts/WrappedIbbtc.sol#L110
https://github.com/code-423n4/2021-10-badgerdao/blob/9c0ea7b3b02675211446f6c81750c5f3c0a86370/contracts/WrappedIbbtcEth.sol#L104
https://github.com/code-423n4/2021-10-badgerdao/blob/9c0ea7b3b02675211446f6c81750c5f3c0a86370/contracts/WrappedIbbtcEth.sol#L123

Tools Used

Manual analysis

Recommended Mitigation Steps

Change the variable to External

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          jah issue #3

384b920

Collaborator

0xleastwood commented Dec 4, 2021 •

edited

Combining issue with #2 and #4

This was referenced Dec 4, 2021

Gas Saving by changing the visibility of initialize function from public to externa #2

Closed

Gas Saving by changing the visibility of functions from public to external To save gas #4

Closed

Some functions can be external #30

Closed

Methods should be declared external #53

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment