Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused local variable in _latestRoundData (ChainlinkOracleWrapper.sol) #2

Closed
code423n4 opened this issue Oct 8, 2021 · 1 comment
Closed

Unused local variable in _latestRoundData (ChainlinkOracleWrapper.sol) #2

code423n4 opened this issue Oct 8, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Warden finding sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

ye0lde

Vulnerability details

Impact

Code Clarity

Proof of Concept

Parameter "startedAt" is not used
https://github.com/tracer-protocol/perpetual-pools-contracts/blob/646360b0549962352fe0c3f5b214ff8b5f73ba51/contracts/implementation/ChainlinkOracleWrapper.sol#L61

Tools Used

Visual Studio Code

Recommended Mitigation Steps

Remove the unused local variable (replace with a comma)
@code423n4 code423n4 added bug Warden finding 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation labels Oct 8, 2021
code423n4 added a commit that referenced this issue Oct 8, 2021
@code423n4
ye0lde issue #2
5d23953
sporejack added a commit to mycelium-ethereum/perpetual-pools-contracts that referenced this issue Oct 18, 2021
@sporejack
Fixes code-423n4/2021-10-tracer-findings#2
52af0bd
@sporejack sporejack mentioned this issue Oct 18, 2021
Merged
@CalabashSquash CalabashSquash added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 28, 2021
@GalloDaSballo
Copy link
Collaborator

Agree with the warden, the sponsor confirms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Warden finding sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @CalabashSquash @code423n4