Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas: Inefficient modulo computation #22

Open
code423n4 opened this issue Oct 13, 2021 · 2 comments
Open

Gas: Inefficient modulo computation #22

code423n4 opened this issue Oct 13, 2021 · 2 comments
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

PoolFactory.uint2str computes i % 10 as uint8(_i - (_i / 10) * 10).
This intuitively seems more gas-expensive than doing i % 10.
Consider using i % 10 instead which also makes the code simpler to read.
code423n4 added a commit that referenced this issue Oct 13, 2021
@code423n4
cmichel issue #22
b3e30cf
@CalabashSquash CalabashSquash added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 17, 2021
@CalabashSquash
Copy link
Collaborator

Confirmed, but we will be using the OpenZeppelin library to replace this function anyway.

@GalloDaSballo
Copy link
Collaborator

Agree with the warden, as per: https://github.com/crytic/evm-opcodes
MOD will cost 5 gas which is the same cost as one division
Screenshot 2021-10-29 at 20 20 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @CalabashSquash @code423n4