Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize Storage Slots (LeveragedPool.sol) #3

Open
code423n4 opened this issue Oct 8, 2021 · 1 comment
Open

Minimize Storage Slots (LeveragedPool.sol) #3

code423n4 opened this issue Oct 8, 2021 · 1 comment
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

ye0lde

Vulnerability details

Impact

It is possible to minimize the number of storage slots used by rearranging the state variables in a more efficient way.

Proof of Concept

In LeveragedPool.sol:
https://github.com/tracer-protocol/perpetual-pools-contracts/blob/646360b0549962352fe0c3f5b214ff8b5f73ba51/contracts/implementation/LeveragedPool.sol#L22-L44

Tools Used

Visual Studio Code

Recommended Mitigation Steps

Arrange the uint32, bytes32, and bool variables such that they fit into the same slot.
code423n4 added a commit that referenced this issue Oct 8, 2021
@code423n4
ye0lde issue #3
d5814c6
@CalabashSquash CalabashSquash added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 28, 2021
@GalloDaSballo
Copy link
Collaborator

Would prefer a more direct advice from the warden

That said, bool occupies just 1 bit, the move would be to "pack" all of those variables together (before tokens) to ensure packing saves the extra storage slot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @CalabashSquash @code423n4