Unused Named Returns Can Be Removed #6
Labels
bug
Warden finding
G (Gas Optimization)
sponsor confirmed
Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Handle
ye0lde
Vulnerability details
Impact
Removing unused named return variables can reduce gas usage and improve code clarity.
Proof of Concept
The unused named return variables are here.
ChainlinkOracleWrapper.sol:
https://github.com/tracer-protocol/perpetual-pools-contracts/blob/646360b0549962352fe0c3f5b214ff8b5f73ba51/contracts/implementation/ChainlinkOracleWrapper.sol#L57-L67
LeveragedPool.sol
https://github.com/tracer-protocol/perpetual-pools-contracts/blob/646360b0549962352fe0c3f5b214ff8b5f73ba51/contracts/implementation/LeveragedPool.sol#L327-L340
https://github.com/tracer-protocol/perpetual-pools-contracts/blob/646360b0549962352fe0c3f5b214ff8b5f73ba51/contracts/implementation/LeveragedPool.sol#L353-L355
Tools Used
Visual Studio Code
Recommended Mitigation Steps
Remove the unused named return variables or use them instead of creating additional variables.
The text was updated successfully, but these errors were encountered: