New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos #50

Open

code423n4 opened this issue Nov 22, 2021 · 0 comments

Labels

0 (Non-critical) bug sponsor acknowledged

Contributor

code423n4 commented Nov 22, 2021

Handle

ye0lde

Vulnerability details

Impact

Code clarity

Proof of Concept

"cnstant" to "constant"
https://github.com/code-423n4/2021-11-overlay/blob/1833b792caf3eb8756b1ba5f50f9c2ce085e54d0/contracts/OverlayV1UniswapV3Market.sol#L153

"shars" to "shares"
https://github.com/code-423n4/2021-11-overlay/blob/1833b792caf3eb8756b1ba5f50f9c2ce085e54d0/contracts/collateral/OverlayV1OVLCollateral.sol#L272

"positoin" to "position"
https://github.com/code-423n4/2021-11-overlay/blob/1833b792caf3eb8756b1ba5f50f9c2ce085e54d0/contracts/collateral/OverlayV1OVLCollateral.sol#L355

"appllies" to "applies"
https://github.com/code-423n4/2021-11-overlay/blob/1833b792caf3eb8756b1ba5f50f9c2ce085e54d0/contracts/market/OverlayV1Comptroller.sol#L132

"cnstant" to "constant"
https://github.com/code-423n4/2021-11-overlay/blob/1833b792caf3eb8756b1ba5f50f9c2ce085e54d0/contracts/market/OverlayV1Comptroller.sol#L287

"konws" to "knows"
https://github.com/code-423n4/2021-11-overlay/blob/1833b792caf3eb8756b1ba5f50f9c2ce085e54d0/contracts/market/OverlayV1Comptroller.sol#L341

"from e entry" to "from entry"
https://github.com/code-423n4/2021-11-overlay/blob/1833b792caf3eb8756b1ba5f50f9c2ce085e54d0/contracts/market/OverlayV1Market.sol#L185

"ligher" to "lighter"
https://github.com/code-423n4/2021-11-overlay/blob/1833b792caf3eb8756b1ba5f50f9c2ce085e54d0/contracts/market/OverlayV1OI.sol#L64

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

Correct the typos if the suggestions are valid.

code423n4 added 0 (Non-critical) bug labels

code423n4 added a commit that referenced this issue


          ye0lde issue #50

bb71915

mikeyrf added the sponsor acknowledged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment