Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong comment in claimReward #102

Open
code423n4 opened this issue Dec 4, 2021 · 0 comments
Open

Wrong comment in claimReward #102

code423n4 opened this issue Dec 4, 2021 · 0 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

kenzo

Vulnerability details

The comment in claimReward says:

Allows a receipt token holder (or original depositor in case of a sale) to claim their rewardTokens

However, the function only allows the original depositor to claim the rewards.
Additionally, the C4 readme doesn't mention that the receipt token holder should be able to withdraw the reward.

Impact

Confusion regarding working of protocol.

Proof of Concept

https://github.com/code-423n4/2021-11-streaming/blob/main/Streaming/src/Locke.sol#L553

Recommended Mitigation Steps

Change the comment to reflect the fact that only original depositor may withdraw rewards.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 4, 2021
code423n4 added a commit that referenced this issue Dec 4, 2021
@code423n4
kenzo issue #102
3ebb836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@code423n4