Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Info in Comment in Alchemist.sol (138) #6

Open
code423n4 opened this issue Nov 17, 2021 · 0 comments
Open

Incorrect Info in Comment in Alchemist.sol (138) #6

code423n4 opened this issue Nov 17, 2021 · 0 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

TimmyToes

Vulnerability details

Impact

Developers wishing to interact with yAxis will find it harder to do so.

Proof of Concept

Lines 138 of Alchemist.sol
/// @dev The percent of each profitable harvest that will go to the rewards contract.
This comment is incorrect. The borrow fee is charged on mint against debt, not harvest.

Recommended Mitigation Steps

Edit the comment.
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 17, 2021
code423n4 added a commit that referenced this issue Nov 17, 2021
@code423n4
TimmyToes issue #6
3cfa07c
@Xuefeng-Zhu Xuefeng-Zhu added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 23, 2021
@Xuefeng-Zhu Xuefeng-Zhu mentioned this issue Dec 9, 2021
Closed
@Xuefeng-Zhu Xuefeng-Zhu added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xuefeng-Zhu @code423n4