Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same module can be added several times #135

Open
code423n4 opened this issue Dec 22, 2021 · 1 comment
Open

Same module can be added several times #135

code423n4 opened this issue Dec 22, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The NFTXEligibilityManager.addModule function allows adding the same implementation several times and does not check for duplicates.
This can lead to issues when updating a module through updateModule as only a single module is updated.

Recommended Mitigation Steps

Check if the implementation is already assigned to a module.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 22, 2021
code423n4 added a commit that referenced this issue Dec 22, 2021
@code423n4
cmichel issue #135
fd0a9ac
@0xKiwi 0xKiwi added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Dec 31, 2021
@0xKiwi
Copy link
Collaborator

0xKiwi commented Dec 31, 2021

Fair check, but this is a very well controlled part of the protocol. Acknowledging.

@dmvt dmvt mentioned this issue Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0xKiwi @code423n4