Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unchecked directive can save gas #43

Closed
code423n4 opened this issue Dec 11, 2021 · 1 comment
Closed

Adding unchecked directive can save gas #43

code423n4 opened this issue Dec 11, 2021 · 1 comment
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

defsec

Vulnerability details

Impact

For the arithmetic operations that will never over/underflow, using the unchecked directive (Solidity v0.8 has default overflow/underflow checks) can save some gas from the unnecessary internal over/underflow checks.

Proof of Concept

https://github.com/pooltogether/v4-periphery/blob/b520faea26bcf60371012f6cb246aa149abd3c7d/contracts/TwabRewards.sol#L98

Tools Used

None

Recommended Mitigation Steps

Consider applying unchecked arithmetic where overflow/underflow is not possible.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Dec 11, 2021
code423n4 added a commit that referenced this issue Dec 11, 2021
@PierrickGT
Copy link
Member

Duplicate of #111

@PierrickGT PierrickGT marked this as a duplicate of #111 Dec 14, 2021
@PierrickGT PierrickGT self-assigned this Dec 14, 2021
@PierrickGT PierrickGT added the duplicate This issue or pull request already exists label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Development

No branches or pull requests

2 participants