Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unlockShares wrong comment #135

Open
code423n4 opened this issue Dec 15, 2021 · 0 comments
Open

unlockShares wrong comment #135

code423n4 opened this issue Dec 15, 2021 · 0 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The strategy contracts define an unlockShares function that must accept an asset parameter as the share token (yield token, aToken, cToken, etc.), otherwise, the code does not work.
However, all comments say that asset is the address of the underlying token.

/**
  * @notice Used to unlock shares
  * @param asset the address of underlying token
  * @param amount the amount of shares to unlock
  * @return received amount of shares received
  **/
function unlockShares(address asset, uint256 amount) external override onlySavingsAccount nonReentrant returns (uint256) {
    if (amount == 0) {
        return 0;
    }
}

Recommended Mitigation Steps

Fix the comments for all unlockShares by saying asset is the share token, not the underlying token.

@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 15, 2021
code423n4 added a commit that referenced this issue Dec 15, 2021
@ritik99 ritik99 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

2 participants