Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VaderMath:calculateSwapReverse require statement change to <= instead of < #61

Open
code423n4 opened this issue Dec 21, 2021 · 0 comments
Open

VaderMath:calculateSwapReverse require statement change to <= instead of < #61

code423n4 opened this issue Dec 21, 2021 · 0 comments
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working VaderMath

Comments

@code423n4
Copy link
Contributor

Handle

GiveMeTestEther

Vulnerability details

The require statement checks y4 < reserveOut, but the derivation allows y4 <= reserveOut

Impact

https://github.com/code-423n4/2021-12-vader/blob/fd2787013608438beae361ce1bb6d9ffba466c45/contracts/dex/math/VaderMath.sol#L131
https://github.com/code-423n4/2021-12-vader/blob/fd2787013608438beae361ce1bb6d9ffba466c45/contracts/dex/math/VaderMath.sol#L135

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.

Recommended Mitigation Steps

  • change < to <=
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Dec 21, 2021
code423n4 added a commit that referenced this issue Dec 21, 2021
@code423n4
GiveMeTestEther issue #61
088a1a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working VaderMath
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@code423n4 @0xstormtrooper