Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a not needed variable #142

Open
code423n4 opened this issue Jan 31, 2022 · 1 comment
Open

a not needed variable #142

code423n4 opened this issue Jan 31, 2022 · 1 comment
Labels
bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

CertoraInc

Vulnerability details

Governable.sol (_governanceApproved() function)

no need for successfulProposal variable
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jan 31, 2022
code423n4 added a commit that referenced this issue Jan 31, 2022
@code423n4
CertoraInc issue #142
f672ba7
@gititGoro gititGoro added sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) labels Feb 3, 2022
@gititGoro
Copy link
Collaborator

The gas savings is low enough that I'd suggest this be reported as a code quality issue. Having the variable is a bit clumsy looking.

@gititGoro gititGoro added unresolved indicate confirmed issues that haven't been resolved with a PR and removed unresolved indicate confirmed issues that haven't been resolved with a PR labels May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gititGoro @code423n4