Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary constructor #18

Open
code423n4 opened this issue Jan 27, 2022 · 1 comment
Open

Unnecessary constructor #18

code423n4 opened this issue Jan 27, 2022 · 1 comment
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

robee

Vulnerability details

The following constructors are empty.
(A similar issue code-423n4/2021-11-fei-findings#12)

    Flan.sol.constructor
    TokenProxyRegistry.sol.constructor
    BurnFlashStakeDeposit.sol.constructor
    FlashGovernanceArbiter.sol.constructor
    SetAssetApprovalProposal.sol.constructor
    ToggleWhitelistProposalProposal.sol.constructor
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jan 27, 2022
code423n4 added a commit that referenced this issue Jan 27, 2022
@gititGoro gititGoro added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Jan 31, 2022
@gititGoro
Copy link
Collaborator

My preference is that empty constructors improve code readability. They've saved me thought and time, similar to reducing context switching. But I'm willing to be argued out of this position.

@gititGoro gititGoro added unresolved indicate confirmed issues that haven't been resolved with a PR and removed unresolved indicate confirmed issues that haven't been resolved with a PR labels May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

2 participants