Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resume() can be called by anyone in IndexTemplate.sol #129

Open
code423n4 opened this issue Jan 11, 2022 · 0 comments · Fixed by InsureDAO/pool-contracts#82
Open

resume() can be called by anyone in IndexTemplate.sol #129

code423n4 opened this issue Jan 11, 2022 · 0 comments · Fixed by InsureDAO/pool-contracts#82
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

p4st13r4

Vulnerability details

Impact

The resume function can be called by any user, at any time, even when the Index contract is not locked. There should be a check preventing it from being called unless the contract is locked

Proof of Concept

https://github.com/code-423n4/2022-01-insure/blob/main/contracts/IndexTemplate.sol#L459

Tools Used

Editor

Recommended Mitigation Steps

Add a require on top:

require(locked);
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Jan 11, 2022
code423n4 added a commit that referenced this issue Jan 11, 2022
@code423n4
p4st13r4 issue #129
f7b8497
@oishun1112 oishun1112 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 17, 2022
@0xkenta 0xkenta mentioned this issue Jan 22, 2022
Merged
@oishun1112 oishun1112 added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue#129
2 participants
@oishun1112 @code423n4