Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec error on function: Factory:approveTemplate #296

Open
code423n4 opened this issue Jan 13, 2022 · 1 comment
Open

Spec error on function: Factory:approveTemplate #296

code423n4 opened this issue Jan 13, 2022 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

Dravee

Vulnerability details

The spec doesn't match with the comments in the code here:

Code: https://github.com/code-423n4/2022-01-insure/blob/main/contracts/Factory.sol#L90-L91
Spec: https://insuredao.gitbook.io/developers/market/factory#approvetemplate

Here, the spec doesn't mention _isOpen and seem to confuse the _approval description with what _isOpen should be.

Tools Used

VS Code

Recommended Mitigation Steps

My guess is that the spec should be corrected
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Jan 13, 2022
code423n4 added a commit that referenced this issue Jan 13, 2022
@code423n4
Dravee issue #296
94289fc
@oishun1112 oishun1112 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 19, 2022
@oishun1112
Copy link
Collaborator

https://app.gitbook.com/s/1LzBDG6XOM2hzmw9AjXY/market/factory#approvetemplate

@oishun1112 oishun1112 added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oishun1112 @code423n4