Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require with empty message #18

Open
code423n4 opened this issue Jan 27, 2022 · 2 comments
Open

Require with empty message #18

code423n4 opened this issue Jan 27, 2022 · 2 comments
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments)

Comments

@code423n4
Copy link
Contributor

Handle

robee

Vulnerability details

The following requires are with empty messages.
This is very important to add a message for any require. Such that the user has enough
information to know the reason of failure:

    Solidity file: BalanceHandler.sol, In line 48 with Empty Require message.
    Solidity file: SafeInt256.sol, In line 47 with Empty Require message.
    Solidity file: EIP1271Wallet.sol, In line 84 with Empty Require message.
    Solidity file: Bitmap.sol, In line 17 with Empty Require message.
    Solidity file: Bitmap.sol, In line 28 with Empty Require message.
    Solidity file: BalanceHandler.sol, In line 29 with Empty Require message.
    Solidity file: BalanceHandler.sol, In line 46 with Empty Require message.
    Solidity file: SafeInt256.sol, In line 43 with Empty Require message.
    Solidity file: Bitmap.sol, In line 50 with Empty Require message.
    Solidity file: TreasuryManager.sol, In line 60 with Empty Require message.
    Solidity file: SafeInt256.sol, In line 72 with Empty Require message.
    Solidity file: EmptyProxy.sol, In line 16 with Empty Require message.
    Solidity file: BalanceHandler.sol, In line 49 with Empty Require message.
    Solidity file: SafeInt256.sol, In line 61 with Empty Require message.
    Solidity file: SafeInt256.sol, In line 67 with Empty Require message.
    Solidity file: SafeInt256.sol, In line 36 with Empty Require message.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Jan 27, 2022
code423n4 added a commit that referenced this issue Jan 27, 2022
@jeffywu jeffywu added the disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) label Feb 6, 2022
@jeffywu
Copy link
Collaborator

jeffywu commented Feb 6, 2022

Should be Non Critical

@pauliax
Copy link
Collaborator

pauliax commented Feb 13, 2022

Agree with the sponsor, the protocol is not at risk, it is a non-critical recommendation.

@pauliax pauliax added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments)
Projects
None yet
Development

No branches or pull requests

3 participants