Inclusive checks in LaunchEvent.sol for time-management

[code423n4]

Handle

Dravee

Vulnerability details

These checks should be inclusive:

contracts\LaunchEvent.sol:182:                block.timestamp > phase3Start + issuerTimelock,
contracts\LaunchEvent.sol:187:                block.timestamp > phase3Start + userTimelock,
contracts\LaunchEvent.sol:250:            _issuerTimelock > _userTimelock,
contracts\LaunchEvent.sol:254:            _auctionStart > block.timestamp,
contracts\LaunchEvent.sol:291:        if (block.timestamp < auctionStart || auctionStart == 0) {
contracts\LaunchEvent.sol:293:        } else if (block.timestamp < auctionStart + PHASE_ONE_DURATION) {
contracts\LaunchEvent.sol:554:        if (timeElapsed < PHASE_ONE_NO_FEE_DURATION) {
contracts\LaunchEvent.sol:556:        } else if (timeElapsed < PHASE_ONE_DURATION) {

Also, strict inequalities add a check of non equality which costs around 3 gas, therefore inclusive checks are cheaper gas-wise. Use them when possible.