Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LaunchEvent's createPair calls token.decimals() twice #264

Closed
code423n4 opened this issue Jan 27, 2022 · 1 comment
Closed

LaunchEvent's createPair calls token.decimals() twice #264

code423n4 opened this issue Jan 27, 2022 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

hyh

Vulnerability details

Impact

Gas is overspent first of all on function call

Proof of Concept

wavaxReserve * 10**token.decimals() is computed twise when the condition is true:

https://github.com/code-423n4/2022-01-trader-joe/blob/main/contracts/LaunchEvent.sol#L396-398

Recommended Mitigation Steps

Consider saving wavaxReserve * 10**token.decimals() to memory and reuse inside the if statement
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jan 27, 2022
code423n4 added a commit that referenced this issue Jan 27, 2022
@code423n4
hyh issue #264
44f99d2
@cryptofish7 cryptofish7 added the duplicate This issue or pull request already exists label Jan 31, 2022
@cryptofish7
Copy link
Collaborator

Duplicate of #236

@cryptofish7 cryptofish7 marked this as a duplicate of #236 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cryptofish7 @code423n4