Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated storage access #300

Open
code423n4 opened this issue Jan 27, 2022 · 0 comments
Open

Repeated storage access #300

code423n4 opened this issue Jan 27, 2022 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

Avoid repeated storage access:

  require(
      user.balance > 0,
      "LaunchEvent: expected user to have non-zero balance to perform emergency withdraw"
  );
  uint256 balance = user.balance;

Proposed improvement:

  uint256 balance = user.balance;
    require(
      balance > 0,
      "LaunchEvent: expected user to have non-zero balance to perform emergency withdraw"
  );
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jan 27, 2022
code423n4 added a commit that referenced this issue Jan 27, 2022
@cryptofish7 cryptofish7 added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

2 participants